Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs-site) remove free trial notes #11729

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix(docs-site) remove free trial notes #11729

merged 4 commits into from
Oct 28, 2024

Conversation

jayacryl
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the community-contribution PR or Issue raised by member(s) of DataHub Community label Oct 28, 2024
@github-actions GitHub Actions
Copy link

Hello @jayacryl 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

maggiehays
maggiehays approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@maggiehays maggiehays left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayacryl not a blocker, but while we're in this page we should consider bumping the font sizes on the Weekly Live Demo CTA on the /cloud page:
CleanShot 2024-10-28 at 16 52 38

Otherwise, LGTM - pinged Lydia in the channel for her review

@jayacryl
Copy link
Collaborator Author

jayacryl commented Oct 28, 2024 •
edited
Loading

@maggiehays i already bumped it up in the solutions page PR, but ill copy it here so it gets out quicker

How's this:
image

@maggiehays
Copy link
Collaborator

@jayacryl got signoff from Lydia - good to ship

@jayacryl jayacryl merged commit ea7bdca into master Oct 28, 2024
37 checks passed
@jayacryl jayacryl deleted the jp--fix-trial branch October 28, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggiehays maggiehays maggiehays approved these changes

@yoonhyejin yoonhyejin Awaiting requested review from yoonhyejin

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayacryl @maggiehays